Skip to content

feat(doctor): surface static bytes-at-rest validation findings (#133) - #340

Merged
ScriptedAlchemy merged 1 commit into
mainfrom
wave/133-doctor-static
Sep 2, 2026
Merged

feat(doctor): surface static bytes-at-rest validation findings (#133)#340
ScriptedAlchemy merged 1 commit into
mainfrom
wave/133-doctor-static

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Summary

The final #133 slice: the read-only install Doctor now surfaces pinned static bytes-at-rest validation findings, reusing the ecosystem validators this issue landed — never spawning host CLIs, never repairing, never exchanging live protocol traffic (that lane stays with #218).

  • Reuse seams, no forks: the host-validation modules now export pure byte lanes — validateClaudePluginFiles (drives the Claude adapter's own pinned document contracts incl. wildcard paths), validateCodexPluginFiles (the pinned-document lane extracted from feat(codex): validate bundles against pinned schemas with honest host-devtools evidence (#133) #326), and validateCursorPluginFiles / validateCursorPluginSymlinks (extracted from feat(cursor): validate bundles against pinned schemas and loader contract with honest devtools evidence (#133) #327, with a parameterizable symlink-containment root). validateClaudePlugin/validateCodexPlugin/validateCursorPlugin behavior is unchanged (they now compose the exported lanes).
  • doctor --from (AB7319): each host tree resolved from the supplied bundle is validated against its pinned document schemas and process-free loader rules; error findings demote the bundle finding to corrupt and retain the originating build-validator code in the message.
  • Installed Cursor inventory (AB7320), honesty-calibrated to the pinned loader evidence: plugins resolving the .cursor-plugin/plugin.json manifest get the full pinned lane (document schemas, token-location rules); plugins using the other loader-accepted manifest flavors (.claude-plugin/plugin.json, root plugin.json — pinned as legitimately loadable, incl. the portable: adopt Agent Plugins 1.0.0 as the pinned portable contract #306 portable dogfood proof) are NOT branded corrupt: they get an honest info naming the flavor plus the one check that is loader-pinned for every local plugin — symlink realpath containment within ~/.cursor/plugins/local (not the individual plugin directory, matching the pinned rejection rule).
  • No wire-contract change: findings ride the existing per-host diagnostics arrays and the existing corrupt state, so the Workbench discovery contract, service mapping, and decoder are untouched; CLI human/--json output and exit-code semantics (nonzero only on errors) are unchanged.
  • Diagnostics AB7319AB7320 registered (AB7317/7318 were taken by the runtime-identity lane that landed mid-wave).

Changeset: minor, agent-bundle.

Test plan (all local, on the rebase over 27a0d59)

  • pnpm build
  • pnpm typecheck
  • pnpm lint — 0 errors, 0 warnings (1018 files)
  • pnpm test:unit — 2624 passed, 0 failed
  • Doctor suite extensions: schema-violating .cursor-plugin install → corrupt + AB7320 error; .claude-plugin/plugin.json flavors stay installed with honest info; local-root symlink escape → corrupt, intra-local-root symlink → clean; --from static findings per host; fixtures upgraded to pinned-schema-valid bytes

Tracking

Reuse process-free pinned host validation lanes so Doctor detects corrupt supplied bundles and installed Cursor plugins without misclassifying loader-supported manifest flavors.
@changeset-bot

changeset-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: eb0e732

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
agent-bundle Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ScriptedAlchemy
ScriptedAlchemy merged commit 892eed0 into main Sep 2, 2026
4 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-02T23:45:58.669559Z eb0e732 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant